Open external links in new tabs by Crabcyborg · Pull Request #3249 · Strategy11/formidable-forms

Crabcyborg · 2026-08-17T21:12:23Z

Summary by CodeRabbit

User Experience
- Upgrade, support, documentation, demo, and learning links now open in a new browser tab.
- Added security protection to links opened in new tabs.
- Upgrade actions in application modals now open their destination in a new tab.
- Error modal continue actions support configurable link targets.
- Inbox links preserve supported target and security attributes.

coderabbitai · 2026-08-17T21:12:34Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d215891-8574-44bb-baeb-ccfffb9fdeea

📥 Commits

Reviewing files that changed from the base of the PR and between b55dcfb and 5a79bef.

📒 Files selected for processing (15)

classes/controllers/FrmAppController.php
classes/helpers/FrmAppHelper.php
classes/models/FrmAntiSpam.php
classes/models/FrmMigrate.php
classes/views/addons/min-version-notice.php
classes/views/applications/header.php
classes/views/frm-forms/error-modal.php
classes/views/frm-settings/license_box.php
classes/views/inbox/list.php
classes/views/shared/admin-header.php
classes/views/shared/upgrade_overlay.php
classes/views/shared/views-info.php
classes/views/summary-emails/base.php
classes/views/test-mode/container.php
js/admin/applications.js

📝 Walkthrough

Walkthrough

Changes

The change updates admin links to open in new tabs with rel="noopener". Error-modal continue links now support configurable targets. Inbox CTA sanitization permits target and rel attributes.

External link handling

Layer / File(s)	Summary
Error modal continue target `classes/controllers/FrmAppController.php`, `classes/views/frm-forms/error-modal.php`	The error modal accepts `continue_target` and builds its anchor attributes dynamically.
Inbox CTA attributes `classes/models/FrmMigrate.php`, `classes/views/inbox/list.php`	Missing-table documentation links use new-tab attributes. Inbox CTA sanitization permits `href`, `target`, and `rel`.
Admin external links `classes/helpers/FrmAppHelper.php`, `classes/models/FrmAntiSpam.php`, `classes/views/addons/min-version-notice.php`, `classes/views/applications/header.php`, `classes/views/frm-settings/license_box.php`, `classes/views/shared/*`, `classes/views/summary-emails/base.php`, `classes/views/test-mode/container.php`, `js/admin/applications.js`	Upgrade, support, documentation, license, demo, renewal, and application links now open in new tabs with noopener protection.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: truongwp

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch open_external_links_in_new_tabs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-08-17T21:14:00Z

DeepSource Code Review

We reviewed changes in b55dcfb...5a79bef on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Aug 27, 2026 12:17p.m.	Review ↗
JavaScript		Aug 27, 2026 12:17p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-08-17T21:14:36Z

 					</p>
 					<?php if ( $is_pro ) { ?>
-						<a href="<?php echo esc_url( $default_link ); ?>" class="button button-primary frm-button-primary frm-upgrade-link" data-default="<?php echo esc_url( $default_link ); ?>">
+						<a href="<?php echo esc_url( $default_link ); ?>" class="button button-primary frm-button-primary frm-upgrade-link" target="_blank" rel="noopener noreferrer" data-default="<?php echo esc_url( $default_link ); ?>">


Variable $default_link might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

codecov · 2026-08-17T21:16:31Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.47%. Comparing base (58a3a7e) to head (91faadf).
⚠️ Report is 140 commits behind head on master.

Files with missing lines	Patch %	Lines
classes/models/FrmMigrate.php	0.00%	2 Missing ⚠️
classes/controllers/FrmAppController.php	0.00%	1 Missing ⚠️
classes/helpers/FrmAppHelper.php	0.00%	1 Missing ⚠️
classes/models/FrmAntiSpam.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3249      +/-   ##
============================================
+ Coverage     26.30%   28.47%   +2.17%     
- Complexity     9466     9596     +130     
============================================
  Files           155      159       +4     
  Lines         31689    32392     +703     
============================================
+ Hits           8336     9224     +888     
+ Misses        23353    23168     -185

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Open external links in new tabs

91faadf

Crabcyborg added this to the 6.35 milestone Aug 17, 2026

Crabcyborg added run analysis run tests labels Aug 17, 2026

deepsource-io Bot reviewed Aug 17, 2026

View reviewed changes

Use noopener

da174fb

NathanaelJonesIreland mentioned this pull request Aug 18, 2026

Derive the generated stylesheet's cache-busting version from its content #3242

Open

Crabcyborg added 2 commits August 27, 2026 09:10

Merge branch 'master' into open_external_links_in_new_tabs

f09f28d

Stop inlining php in HTML

5a79bef

Crabcyborg marked this pull request as ready for review August 27, 2026 12:18

Crabcyborg merged commit 5de667c into master Aug 27, 2026
20 of 22 checks passed

Crabcyborg deleted the open_external_links_in_new_tabs branch August 27, 2026 12:20

Navigation Menu

Uh oh!

Open external links in new tabs - #3249

Open external links in new tabs#3249
Crabcyborg merged 4 commits into
masterfrom
open_external_links_in_new_tabs

Crabcyborg commented Aug 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 17, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Uh oh!

deepsource-io Bot commented Aug 17, 2026 •

edited

Loading

Uh oh!

deepsource-io Bot Aug 17, 2026

Uh oh!

codecov Bot commented Aug 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Crabcyborg commented Aug 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Uh oh!

deepsource-io Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Aug 17, 2026

Choose a reason for hiding this comment

Variable $default_link might not be defined

Uh oh!

codecov Bot commented Aug 17, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Crabcyborg commented Aug 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 17, 2026 •

edited

Loading

deepsource-io Bot commented Aug 17, 2026 •

edited

Loading